Skip to content

Remove -stripsymbols option from build scripts#34076

Merged
akoeplinger merged 1 commit intodotnet:masterfrom
am11:feature/symbol-stripping
Mar 25, 2020
Merged

Remove -stripsymbols option from build scripts#34076
akoeplinger merged 1 commit intodotnet:masterfrom
am11:feature/symbol-stripping

Conversation

@am11
Copy link
Member

@am11 am11 commented Mar 25, 2020

Symbol stripping is on by default in cmake scripts. This cleans up the remaining places where the no-op -stripsymbols option is passed from shell scripts via .proj files.

Fixes #32957

cc @janvorli

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@akoeplinger akoeplinger merged commit 6eedf8e into dotnet:master Mar 25, 2020
@am11 am11 deleted the feature/symbol-stripping branch March 26, 2020 03:48
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

macOS debug / checked builds don't have full debug info

4 participants