Skip to content

Guard against deserializing types with open generics #34163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
layomia merged 7 commits into from
Mar 31, 2020
Merged

Guard against deserializing types with open generics #34163

layomia merged 7 commits into from
Mar 31, 2020

Conversation

@layomia
Copy link
Contributor

@layomia layomia commented Mar 26, 2020

Fixes #30852.

@layomia layomia added this to the 5.0 milestone Mar 26, 2020
@layomia layomia requested review from jozkee and steveharter March 26, 2020 22:14
@layomia layomia requested a review from ahsonkhan as a code owner March 26, 2020 22:14
@layomia layomia self-assigned this Mar 26, 2020
@layomia layomia closed this Mar 26, 2020
@layomia layomia reopened this Mar 26, 2020
steveharter
steveharter reviewed Mar 30, 2020
View reviewed changes
jozkee
jozkee reviewed Mar 30, 2020
View reviewed changes
jozkee
jozkee reviewed Mar 30, 2020
View reviewed changes
jozkee
jozkee reviewed Mar 30, 2020
View reviewed changes
jozkee
jozkee reviewed Mar 30, 2020
View reviewed changes
@layomia layomia requested review from jozkee and steveharter March 31, 2020 16:02
steveharter
steveharter approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@steveharter steveharter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@layomia
Copy link
Contributor Author

layomia commented Mar 31, 2020

CI failure - #28553.

@layomia layomia merged commit f973e96 into dotnet:master Mar 31, 2020
@layomia layomia deleted the open_generics branch April 1, 2020 01:47
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub left review comments

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan

@jozkee jozkee Awaiting requested review from jozkee

+2 more reviewers

@am11 am11 am11 left review comments

@steveharter steveharter steveharter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@layomia layomia

Labels

area-System.Text.Json

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

JsonSerializer.Deserialize results in a null ref when attempting to deserialize open generic Nullable<>

5 participants

@layomia @stephentoub @am11 @steveharter @jozkee