Cache parameterized ctor delegates in class info rather than converter #34248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveharter
reviewed
Mar 30, 2020
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonClassInfo.cs
Outdated
Show resolved
Hide resolved
jozkee
reviewed
Mar 30, 2020
...xt/Json/Serialization/Converters/Object/ObjectWithParameterizedConstructorConverter.Large.cs
Outdated
Show resolved
Hide resolved
...xt/Json/Serialization/Converters/Object/ObjectWithParameterizedConstructorConverter.Large.cs
Outdated
Show resolved
Hide resolved
...xt/Json/Serialization/Converters/Object/ObjectWithParameterizedConstructorConverter.Large.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverter.cs
Outdated
Show resolved
Hide resolved
steveharter
approved these changes
Mar 31, 2020
Contributor
steveharter
left a comment
steveharter
left a comment
There was a problem hiding this comment.
LGTM
CI test failures are not related.
Contributor
Author
|
CI failure - #28553. |
layomia
added a commit
to layomia/dotnet_runtime
that referenced
this pull request
Apr 1, 2020
dotnet#34248) * Cache parameterized ctor delegates in class info rather than converter * Address review feedback - move delegate assignment to start of deserialization * Address review feedback - nullability
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33928.
Caching parameterized ctor delegates in converters is not thread-safe. The delegates should be stored on the
JsonClassInfoinstance for the type, which is shared across all instances of the converter.