Fix Ref and impl dll locations in transport pack#34252
Closed
Fix Ref and impl dll locations in transport pack#34252
Conversation
Member
|
Crud, sorry for screwing this up. I think this isn't quite right still. We want the XML to be next to ref. I put up a PR with what I believe the right fix should be. Again, sorry for this. |
Member
Contributor
Author
|
Sounds good. |
Contributor
Author
|
Yea I wasn't sure why the xml docs were in runtime either, but I just worked around it so I didn't bother with changing it in the PR |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @ericstj, while I was trying to ingest the transport pack, I found that the location for ref and impl assemblies are backwards.
FYI, other than that, I've got things building on my local box but I'm still working on getting all the tests fixed up. cc @maryamariyan