Fix unsupported instruction set handling in crossgen2 #34605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
davidwrighton
commented
Apr 6, 2020
davidwrighton
commented
- A refactoring during crossgen2 production in the recent pr broke the unsupported instruction set mode for crossgen
- Tested via manual inspection of the JIT\HardwareIntrinsics\X86\Avx\Sqrt_r test.
Member
Author
|
@MichalStrehovsky This fixes the issue you noted after the #33274 was merged. |
lpereira
reviewed
Apr 6, 2020
| #endif | ||
| { | ||
| _actualInstructionSetSupported.AddInstructionSet(instructionSet); | ||
| _actualInstructionSetUnsupported.AddInstructionSet(instructionSet); |
Contributor
There was a problem hiding this comment.
Ah, the classic if (cond) { stuff } else { exact same stuff } attacks again
MichalStrehovsky
approved these changes
Apr 7, 2020
Member
MichalStrehovsky
left a comment
MichalStrehovsky
left a comment
There was a problem hiding this comment.
LGTM. Maybe this is going to address #34628?
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.