Skip to content

Override IsByRefLike on S.R.E.*Builder classes #34846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephentoub merged 5 commits into from
Apr 20, 2020
Merged

Override IsByRefLike on S.R.E.*Builder classes #34846

stephentoub merged 5 commits into from
Apr 20, 2020

Conversation

@marcusturewicz
Copy link
Contributor

@marcusturewicz marcusturewicz commented Apr 11, 2020

Fixes #8828

@marcusturewicz marcusturewicz marked this pull request as ready for review April 11, 2020 03:00
@stephentoub
Copy link
Member

stephentoub commented Apr 12, 2020

Thanks for the PR. Can you please add tests to go along with this?

@jaredpar jaredpar mentioned this pull request Apr 13, 2020
Closed
@stephentoub
Copy link
Member

stephentoub commented Apr 17, 2020

The test failures are valid and are because a similar change needs to be made in mono's corelib.

@marcusturewicz
Copy link
Contributor Author

marcusturewicz commented Apr 18, 2020

The test failures are valid and are because a similar change needs to be made in mono's corelib.

Ahh yes, there's two runtimes now hey. I'll fix that

stephentoub
stephentoub approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@stephentoub stephentoub merged commit cfb1335 into dotnet:master Apr 20, 2020
@marcusturewicz marcusturewicz deleted the issue-8828 branch April 20, 2020 21:49
@jaredpar jaredpar mentioned this pull request Apr 23, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marek-safar marek-safar marek-safar approved these changes

@stephentoub stephentoub stephentoub approved these changes

@GrabYourPitchforks GrabYourPitchforks Awaiting requested review from GrabYourPitchforks

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@EgorBo EgorBo Awaiting requested review from EgorBo

@steveisok steveisok Awaiting requested review from steveisok

@vargaz vargaz Awaiting requested review from vargaz

Assignees

No one assigned

Labels

area-System.Reflection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Override IsByRefLike property getter on RefEmit.***Builder classes.

4 participants

@marcusturewicz @stephentoub @marek-safar @Dotnet-GitSync-Bot