Improve crossgen HWIntrinsics handling#34849
Merged
Merged
Conversation
|
Tagging @ViktorHofer as an area owner. If you would like to be tagged for a label, please notify danmosemsft. |
saucecontrol
commented
Apr 11, 2020
tannergooding
approved these changes
Apr 14, 2020
Member
|
Ping @davidwrighton for the secondary sign-off. |
davidwrighton
approved these changes
Apr 14, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34826
In addition to the fix for #34826, I made a couple of improvements:
ArmBaseandAdvSimdas Intrinsic unconditionally on ARM64 to give parity with the way the required SSE and SSE2 ISAs are handled on xArch.X64IsSupportedchecks to remain Intrinsic on x86, so the code under them can be treated as dead.This update shaves 4KiB off the current x86 R2R
System.Private.CoreLibimage, mostly by trimming code protected byBmi1.X64.IsSupportedandLzcnt.X64.IsSupported.cc @davidwrighton @tannergooding