[jit] Add support for fconv.ovf.*.un opcodes #34949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We handle them the same way as non _un versions, by doing a float to int64 conversion followed by a simple integer conversion to the final size.
We no longer need to emulate fconv_ovf_u8_un and rconv_ovf_u8_un since we reuse the mechanism for non _un versions (which uses just the emulation for fconv_ovf_u8 and rconv_ovf_u8) Partly reverts mono/mono@de5dca2.
BrzVlad
requested review from
CoffeeFlux,
SamMonoRT,
alexischr,
lambdageek,
lewurm,
thaystg and
vargaz
as code owners
|
Tagging subscribers to this area: @lewurm |
alexischr
approved these changes
Apr 14, 2020
Fixes src/coreclr/tests/src/JIT/Regression/VS-ia64-JIT/V2.0-Beta2/b309576/bug2.il which was silently failing before
imhameed
approved these changes
Apr 15, 2020
| case STACK_I8: | ||
| ins->opcode = OP_LCONV_TO_R_UN; | ||
| break; | ||
| case STACK_R4: |
Contributor
There was a problem hiding this comment.
This should also fix #34382 (I arrived here just now while looking into this). My only feedback here is that it'd be nice to have a g_assert_not_reached () default case.
This was referenced May 5, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These opcodes have the same effect as their non-un counterpart, since floats are always signed. This means that applying a fconv.ovf.i8.un to a negative float, will result in a negative integer, despite the unsigned suffix (tested against coreclr).
Fixes #34084