Resetting _waitForCompletion to null was removed from DuplexContent#35010
Merged
alnikola merged 3 commits intodotnet:masterfrom Apr 17, 2020
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/ncl |
davidsh
approved these changes
Apr 15, 2020
Contributor
Author
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephentoub
approved these changes
Apr 15, 2020
Contributor
Author
|
/azp stop runtime |
|
Command 'stop' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
Contributor
Author
|
/azp help |
Supported commands
See additional documentation. |
Contributor
Author
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_waitForCompletiongets reset to null inDuplexContent.CompleteandFailwhich leads to race condition withSerializeToStreamAsync. This reset seems redundant since_waitForCompletionis always unconditionally initialized on each call toSerializeToStreamAsync. This PR removes that reset logic.Fixes #33141