Skip to content

Conversation

@AndyAyersMS
Copy link
Member

We were not setting m_Code in the root inline context, and so were
sometimes allowing one level of recursive inlining.

We were not setting `m_Code` in the root inline context, and so were
sometimes allowing one level of recursive inlining.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 15, 2020
@AndyAyersMS
Copy link
Member Author

@dotnet/jit-contrib PTAL

Minimal FX diffs.

We might want to consider recursive inlining someday, but for now we won't do it unless methods have AggressiveInlining.

Found this while looking at test cases for #33529.

PMI CodeSize Diffs for System.Private.CoreLib.dll, framework assemblies for x64 default jit
Summary of Code Size diffs:
(Lower is better)
Total bytes of diff: -434 (-0.00% of base)
    diff is an improvement.
Top file regressions (bytes):
          11 : System.Private.Xml.dasm (0.00% of base)
Top file improvements (bytes):
        -248 : System.Collections.Immutable.dasm (-0.02% of base)
        -146 : Microsoft.CodeAnalysis.VisualBasic.dasm (-0.00% of base)
         -51 : Microsoft.CodeAnalysis.CSharp.dasm (-0.00% of base)
4 total files with Code Size differences (3 improved, 1 regressed), 260 unchanged.
Top method regressions (bytes):
          11 (20.75% of base) : System.Private.Xml.dasm - XmlUntypedStringConverter:.ctor(bool):this
Top method improvements (bytes):
        -248 (-36.15% of base) : System.Collections.Immutable.dasm - Node:Add(Vector`1):Node:this
         -68 (-27.87% of base) : Microsoft.CodeAnalysis.VisualBasic.dasm - Enumerator:PushToken(SyntaxToken):this
         -51 (-35.66% of base) : Microsoft.CodeAnalysis.CSharp.dasm - SourceMemberMethodSymbol:ForceComplete(SourceLocation,CancellationToken):this
         -46 (-23.96% of base) : Microsoft.CodeAnalysis.VisualBasic.dasm - Enumerator:Push(GreenNode):this
         -32 (-35.56% of base) : Microsoft.CodeAnalysis.VisualBasic.dasm - TypeSubstitution:AddPairsIncludingParentToBuilder(ArrayBuilder`1):this
Top method regressions (percentages):
          11 (20.75% of base) : System.Private.Xml.dasm - XmlUntypedStringConverter:.ctor(bool):this
Top method improvements (percentages):
        -248 (-36.15% of base) : System.Collections.Immutable.dasm - Node:Add(Vector`1):Node:this
         -51 (-35.66% of base) : Microsoft.CodeAnalysis.CSharp.dasm - SourceMemberMethodSymbol:ForceComplete(SourceLocation,CancellationToken):this
         -32 (-35.56% of base) : Microsoft.CodeAnalysis.VisualBasic.dasm - TypeSubstitution:AddPairsIncludingParentToBuilder(ArrayBuilder`1):this
         -68 (-27.87% of base) : Microsoft.CodeAnalysis.VisualBasic.dasm - Enumerator:PushToken(SyntaxToken):this
         -46 (-23.96% of base) : Microsoft.CodeAnalysis.VisualBasic.dasm - Enumerator:Push(GreenNode):this
6 total methods with Code Size differences (5 improved, 1 regressed), 243784 unchanged.

Copy link
Member

@erozenfeld erozenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndyAyersMS AndyAyersMS merged commit 103fa2c into dotnet:master Apr 16, 2020
@AndyAyersMS AndyAyersMS deleted the FixRecursiveInlineCheck branch April 16, 2020 22:39
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants