Address the System.Diagnostics Feedback#35582
Merged
Merged
Conversation
Member
Author
|
@noahfalk part of the change, we now keep the order of the tags, baggage, and links as it got added. I consider this not a breaking change. Please advise if you think otherwise. |
stephentoub
reviewed
Apr 29, 2020
stephentoub
reviewed
Apr 29, 2020
stephentoub
reviewed
Apr 29, 2020
noahfalk
approved these changes
Apr 29, 2020
Member
noahfalk
left a comment
noahfalk
left a comment
There was a problem hiding this comment.
A few comments inline, otherwise LGTM
noahfalk
reviewed
Apr 29, 2020
Member
Author
|
@stephentoub are you ok to merge it now? |
stephentoub
reviewed
May 1, 2020
stephentoub
reviewed
May 1, 2020
Member
Author
|
Thanks @stephentoub for your review and feedback. I addressed all of them as you have suggested. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change mainly addresses @stephentoub feedback on the PR #35326.