Fix Unix stack overflow trace logging for native failure locations #35667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When stack overflow happens in native runtime code (e.g. in one of the QCALLs, FCALLs etc.), we do not print stack trace to the console and we fail fast with just a "Stack overflow" message. The reason is that the stack overflow handling is executed on the failing thread and it is not safe to call methods that are not async safe (reentrant). The reason is that we could end up hanging or crashing when trying to report the stack overflow. However, we have the same potential issue on Windows and yet we try to report the stack trace anyways. So this change modifies the behavior on Unix to be the same. I have also added a bunch of stack overflow reporting tests.
jkotas
reviewed
Apr 30, 2020
| @@ -0,0 +1,149 @@ | |||
| using System; | |||
Member
Author
There was a problem hiding this comment.
Oops, thank you for noticing that, fixed.
jkotas
approved these changes
Apr 30, 2020
Member
Author
|
FYI: @danmosemsft |
Member
|
Thanks for doing this @janvorli . This is definitely valuable (just today I was looking at a SO issue reported) |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When stack overflow happens in native runtime code (e.g. in one of the
QCALLs, FCALLs etc.), we do not print stack trace to the console
and we fail fast with just a "Stack overflow" message. The reason is
that the stack overflow handling is executed on the failing thread and
it is not safe to call methods that are not async safe (reentrant).
The reason is that we could end up hanging or crashing when trying to
report the stack overflow.
However, we have the same potential issue on Windows and yet we try to
report the stack trace anyways. So this change modifies the behavior on
Unix to be the same.
I have also added a bunch of stack overflow reporting tests.
Close #35420
Close #32203