UnmanagedCallersOnlyAttribute in load_assembly_and_get_function_pointer #35763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d_get_function_pointer API.
|
Tagging subscribers to this area: @vitek-karas, @swaroop-sridhar |
jkotas
reviewed
May 3, 2020
...oreclr/src/System.Private.CoreLib/src/Internal/Runtime/InteropServices/ComponentActivator.cs
Show resolved
Hide resolved
jkotas
reviewed
May 3, 2020
...oreclr/src/System.Private.CoreLib/src/Internal/Runtime/InteropServices/ComponentActivator.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 3, 2020
...oreclr/src/System.Private.CoreLib/src/Internal/Runtime/InteropServices/ComponentActivator.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 3, 2020
...oreclr/src/System.Private.CoreLib/src/Internal/Runtime/InteropServices/ComponentActivator.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 3, 2020
...oreclr/src/System.Private.CoreLib/src/Internal/Runtime/InteropServices/ComponentActivator.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 3, 2020
...oreclr/src/System.Private.CoreLib/src/Internal/Runtime/InteropServices/ComponentActivator.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 3, 2020
...oreclr/src/System.Private.CoreLib/src/Internal/Runtime/InteropServices/ComponentActivator.cs
Outdated
Show resolved
Hide resolved
vitek-karas
changed the title
Member
Author
|
This will add another location to update in #33582 |
Member
Author
|
@vitek-karas I want to make sure we close the loop on your sentinel comment. Please let me know if a string sentinel rather than a pointer constant is something you feel strongly about. |
jkotas
reviewed
May 3, 2020
jkotas
reviewed
May 3, 2020
...oreclr/src/System.Private.CoreLib/src/Internal/Runtime/InteropServices/ComponentActivator.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 4, 2020
jkotas
reviewed
May 4, 2020
jkotas
reviewed
May 4, 2020
jkotas
reviewed
May 4, 2020
jkotas
reviewed
May 4, 2020
jkotas
reviewed
May 4, 2020
Member
Author
|
@jkotas or @vitek-karas Either of you have any additional comments? |
vitek-karas
approved these changes
May 5, 2020
Member
Author
|
The mono android x86 run is unrelated to this change. |
AaronRobinsonMSFT
deleted the
support_unmanagedcallersonly_in_hostdelegateapi
branch
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @vitek-karas @swaroop-sridhar @elinor-fung