Enable linux OOP unwinder on Windows for cross DAC #35972
Conversation
Add libunwind_xdac Revise CMake files to enable compiling libunwind for UNW_REMOTE_ONLY Add minimum set of posix prototypes and constants to enable compilation Add minimum implementation of posix functions to satisfy linker. Copy freebsd-elf headers from mono include directory Cleanup comment Fix GCC constructs not supported by VC++ Use TARGET variables to configure libunwind Add PAL_VirtualUnwindOutOfProc to libunwind_xdac
|
Tagging subscribers to this area: @tommcdon |
|
@sdmaclea this is overall problematic. We don't want to make any changes to the libunwind sources in our repo since I expect that we would need to update them in the future from the upstream and making them diverse would cause pain once we need to sync. The exception is the CMakeLists.txt which is ours, so we can do whatever we want there. |
| void* mmap(void *addr, size_t length, int prot, int flags, int fd, size_t offset) | ||
| { | ||
| // We shouldn't be doing anything other than anonymous mappings | ||
| if ((flags & MAP_ANON) == 0) |
There was a problem hiding this comment.
nit: This should be MAP_ANONYMOUS as MAP_ANON is deprecated.
| if ((flags & MAP_ANON) == 0) | ||
| return MAP_FAILED; | ||
|
|
||
| return malloc(length); |
There was a problem hiding this comment.
MAP_ANONYMOUS guarantees a zero-initialized buffer, shouldn't we call memset on the buffer that was malloc'ed?
| return 0; | ||
| } | ||
|
|
||
| ssize_t read(int fd, void *buf, size_t count) |
|
Closing in favor of #37521 |
ghost
locked as resolved and limited conversation to collaborators
3 participants
Add libunwind_xdac
Revise CMake files to enable compiling libunwind for UNW_REMOTE_ONLY
Add minimum set of posix prototypes and constants to enable compilation
Add minimum implementation of posix functions to satisfy linker.
Copy freebsd-elf headers from mono include directory
Cleanup comment
Fix GCC constructs not supported by VC++
Use TARGET variables to configure libunwind
Add PAL_VirtualUnwindOutOfProc to libunwind_xdac
/cc @hoyosjs