Mix installer build configurations in PRs as all are Debug now#36081
Merged
Conversation
|
Tagging subscribers to this area: @ViktorHofer |
Member
Author
|
Test rolling build is here: https://dev.azure.com/dnceng/public/_build/results?buildId=636027&view=results This depends on: #36076 |
safern
force-pushed
the
MixInstallerConfigPrs
branch
from
827301f to
db055c6
Compare
ViktorHofer
approved these changes
May 8, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that for installer we build all legs in Debug in PRs and all in Release in CI. Let's add some Release builds for PRs as we do in other parts of the produce to protect from potential regressions on Release only builds like: #35967
cc: @dotnet/runtime-infrastructure