Remove PlatformAbstractions from runtime tests. #36243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to dotnet#3470
eerhardt
added
area-Infrastructure-libraries
and removed
area-Microsoft.Extensions
labels
|
Tagging subscribers to this area: @safern, @ViktorHofer |
tarekgh
reviewed
May 11, 2020
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Unix.cs
Outdated
Show resolved
Hide resolved
tarekgh
reviewed
May 11, 2020
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Unix.cs
Show resolved
Hide resolved
tarekgh
approved these changes
May 11, 2020
Member
tarekgh
left a comment
tarekgh
left a comment
There was a problem hiding this comment.
Added a couple of questions, other than that LGTM.
safern
reviewed
May 11, 2020
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Unix.cs
Outdated
Show resolved
Hide resolved
safern
approved these changes
May 11, 2020
stephentoub
approved these changes
May 12, 2020
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Unix.cs
Outdated
Show resolved
Hide resolved
eerhardt
force-pushed
the
RemovePlatformAbstractionsFromTests
branch
from
6504a43 to
aa91318
Compare
Member
Author
|
The allConfigurations failure is #36285. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3470