-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Build tests as self contained apps for mobile targets #36262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @ViktorHofer |
| <AppleAppBuilderTask | ||
| Arch="$(TargetArchitecture)" | ||
| ProjectName="$(AssemblyName)" | ||
| MonoRuntimeHeaders="$(RuntimePackNativeDir)\include\mono-2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akoeplinger you said you were going to clean these \ up in a follow up PR since you're touching files, but since I'm touching them here, do you want me to do it instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's get this in and I'll do the cleanup, I will need to touch this whole file anyway.
ViktorHofer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This uses the SDK to publish tests as self contained apps before building the app bundle using the built runtime pack.
Where are you using the SDK to publish the tests as self contained apps?
| <SelfContained>true</SelfContained> | ||
| <EnableTargetingPackDownload>false</EnableTargetingPackDownload> | ||
| <PlatformManifestFile /> | ||
| </PropertyGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it too early to enable PublishTrimmed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I did try that in my branch and you'll need to disable trimming on corelib or it crashes at startup. Let's do that in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not disable it but fix it instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah of course, but still in another PR :)
By setting SelfContained = true and the RuntimeIdentifier. Then I intercept the ResolvedRuntimePack and update them to point to the directory where we built them. I didn’t use the publish target because I spoke with @dsplaisted and he said that when you have SelfContained = true and RID set the build output and the publish output are the same for console apps. I don’t know if when we want to publish as trimmed if we will need to use the Publish target. Anyway it will be a simple change by just adding Publish to the DependsOnTargets of PublishAsSelfContained. I had that initially and it work fine. |
I assume you mean for executables that only use the Microsoft.NETCore.App shared framework and probably also for class libraries? |
|
Right. For web apps the output is indeed different. The reason why I relied on the build output was to avoid having to folders that where the same on the output dir. @dsplaisted if we want to enable trimmed publish we will need to call publish, right? |
I think we're going to have to do that b/c enabling |
|
I’ll put up a PR in a few mins so that we can publish trimmed. |
This uses the SDK to publish tests as self contained apps before building the app bundle using the built runtime pack.
I moved the
RunTests.shoutput path toBundleDiras whenever we start sending to helix, there is no need to .zip up the wholeOutDiras we can just send the bundle +RunTests.shscript.