Skip to content

Fix build break by bumping DependencyModel package version #36285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
safern merged 1 commit into from
May 12, 2020
+3 −2
Merged

Fix build break by bumping DependencyModel package version #36285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/libraries/pkg/baseline/packageIndex.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,12 +543,13 @@
"3.1.0",
"3.1.1",
"3.1.2",
"3.1.3"
"3.1.3",
"3.1.4"
],
"BaselineVersion": "5.0.0",
"InboxOn": {},
"AssemblyVersionInPackageVersion": {
"3.1.3.0": "5.0.0",
"3.1.4.0": "5.0.0",
Copy link
Member

@joperezr joperezr May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure about this one but I understand you didn’t do this manually so I’m ok with it

Copy link
Member Author

@eerhardt eerhardt May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did do this manually. 😄

The assembly version in DependencyModel got updated to 3.1.4.0, so I updated this as well.

Copy link
Member Author

@eerhardt eerhardt May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I do it automatically?

Copy link
Member

@ericstj ericstj May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not update this. This is meant to indicate the first package version an assembly version appeared in.

Copy link
Member

@joperezr joperezr May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the break in the build error should tell you the command you have to run in order to fix this automatically

Copy link
Member

@joperezr joperezr May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually do use it to determine which package dependency version other packages will get if they depend on DependencyModel. For example: say you have a library B which depends on DependencyModel, and more specifically they depend on assembly version 3.1.4.0. Our package infrastructure will then come to this table, and check which package version is the one where that assembly version first appeared, (the table above actually looks incorrect as I would assume that it should have something like "3.1.4.0": "3.1.4") and then determine that package B should depend on at least DependencyModel package version 3.1.4. Assuming there is no BaselineVersion for DependencyModel (which in this case we do have one, but let's pretend we don't) then B would depend on 3.1.4 DependencyModel. In this case we do have a BaselineVersion, so even if our package infrastructure chooses package version 3.1.4 for the dependency, it will then baseline up to 5.0.0 because BaselineVersion > InitialChoosenPackageVersion.

Does that sort of make sense?

Copy link
Member

@joperezr joperezr May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I believe that the right contents of that dictionary for DependencyModel should look something like:

      "AssemblyVersionInPackageVersion": {
        "3.1.3.0": "3.1.3",
        "3.1.4.0": "3.1.4",
        "5.0.0.0": "5.0.0"
      }

Copy link
Member Author

@eerhardt eerhardt May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are so far in the CI now, I want to wait for it to finish and merge this to unblock the build. I can put up another change for the above.

Copy link
Member

@joperezr joperezr May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with that as long as we take care of it 😄

Copy link
Member Author

@eerhardt eerhardt May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#36301

"5.0.0.0": "5.0.0"
}
},
Expand Down