Ignore the private key handle cert property for persisted keys #36287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a CERT_CONTEXT value has both property 2 (prov info) and property 78 (ncrypt key handle), prefer to load based on the property 2 state. This avoids a scenario where calling Get[Algorithm]PrivateKey sets the 'CLR IsEphemeral' property on a persisted key, preventing future loads of that key. An alternative approach of preferring the loaded key over the cold-load was not selected to avoid value contamination of ephemeral properties set on the CngKey object directly after the caller calls Get[Algorithm]PrivateKey.
Member
Author
|
/azp run runtime-libraries outerloop-windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephentoub
reviewed
May 12, 2020
src/libraries/System.Security.Cryptography.X509Certificates/tests/Cert.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
May 12, 2020
Member
Author
|
/azp run runtime-libraries outerloop-windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
allConfigurations failure is #36285 |
Member
Author
|
The only outerloop failure was #36207. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a CERT_CONTEXT value has both property 2 (prov info) and property 78
(ncrypt key handle), prefer to load based on the property 2 state.
This avoids a scenario where calling Get[Algorithm]PrivateKey sets the
'CLR IsEphemeral' property on a persisted key, preventing future loads of that key.
An alternative approach of preferring the loaded key over the cold-load was
not selected to avoid value contamination of ephemeral properties set on the
CngKey object directly after the caller calls Get[Algorithm]PrivateKey.
Fixes #36273.