No retyping arm/arm64. #36866
Merged
No retyping arm/arm64. #36866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandreenko
added
the
area-CodeGen-coreclr
sandreenko
force-pushed
the
noRetypingArm
branch
3 times, most recently
from
ebacf18 to
befd9a1
Compare
sandreenko
commented
Jun 5, 2020
src/coreclr/src/jit/morph.cpp
Outdated
Contributor
Author
Contributor
Author
|
PTAL @CarolEidt, @dotnet/jit-contrib |
CarolEidt
approved these changes
Jun 5, 2020
Contributor
CarolEidt
left a comment
CarolEidt
left a comment
There was a problem hiding this comment.
LGTM with a few comments - thanks for expanding the test!
src/coreclr/src/jit/compiler.h
Outdated
|
|
||
| // Returns true if the method returns a value in more than one return register, | ||
| // it should replace/be merged with compMethodReturnsMultiRegRetType when #36868 is fixed. | ||
| bool compMethodReturnsResInMultiplyRegisters() |
Contributor
There was a problem hiding this comment.
Even if temporary, I think it would be good to 1) describe in what way it is different (in particular talk about the special handling required for SIMD types, soon to be additional ones for x64/ux, that are passed in a single register), and 2) rename it to be something like compMethodReturnsMultiRegRegTypeAlternate.
added 3 commits
June 8, 2020 04:40
and disable failung tests with old retyping.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
compDoOldStructRetypingfor arm64 and arm32.Because of #37341 this requires some special handling in import/morph phases.
No diffs with
compDoOldStructRetyping, diffs, when retyping is disabled, are similar to what we saw on x64 and x86 (!compDoOldStructRetyping) around ~0.18% regression because ofASG(LCL_VAR with 1 field, call structhandling.No test failures (note that I will have to disable the test from #37341 because it is failing with
compDoOldStructRetyping), I have triggered jitstress and jitstressregs for the changes.