Pipelines fast-path, return single block outside of lock#36991
Closed
benaadams wants to merge 1 commit into
Closed
Pipelines fast-path, return single block outside of lock#36991benaadams wants to merge 1 commit into
benaadams wants to merge 1 commit into
Conversation
Member
Author
|
Revist post 5.0 |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MemoryBlock.Dispose()is a significant portion ofAdvanceReader; add a fast path so when there is a singleBufferSegmentreturn that inside the lock and return theMemoryBlockoutside; leaving the lock and triggering the callback early.After for Json the majority use the new path: