Add SslStream test for zero-byte reads #37128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl |
wfurt
approved these changes
May 28, 2020
Member
wfurt
left a comment
wfurt
left a comment
There was a problem hiding this comment.
LGTM. There is helper function you can use to simplify TCP connect.
src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamStreamToStreamTest.cs
Outdated
Show resolved
Hide resolved
halter73
reviewed
May 28, 2020
src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamStreamToStreamTest.cs
Outdated
Show resolved
Hide resolved
halter73
approved these changes
May 28, 2020
We have higher-level tests for libraries like WebSockets that validate the behavior of zero-byte reads, but we don't currently have one in System.Net.Security's tests. Adding one.
halter73
approved these changes
May 29, 2020
davidsh
approved these changes
May 29, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have higher-level tests for libraries like WebSockets that validate the behavior of zero-byte reads, but we don't currently have one in System.Net.Security's tests. Adding one.
Closes #37122
cc: @wfurt