Skip to content

[Test] don't use process var in async readers #37259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 2 commits into from
Jun 8, 2020
Merged

[Test] don't use process var in async readers #37259

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f32e130
don't use process var in async readers
Jun 1, 2020
2adbedd
Add comment
Jun 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/coreclr/tests/src/tracing/eventpipe/reverse/reverse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,19 +60,23 @@ public static async Task RunSubprocess(string serverName, Func<Task> beforeExecu

Logger.logger.Log($"running sub-process: {process.StartInfo.FileName} {process.StartInfo.Arguments}");

// use this DateTime rather than process.StartTime since the async callbacks might
// not happen till after the process is no longer around.
DateTime subprocessStartTime = DateTime.Now;

process.OutputDataReceived += new DataReceivedEventHandler((s,e) =>
{
if (!string.IsNullOrEmpty(e.Data))
{
stdoutSb.Append($"\n\t{(DateTime.Now - process.StartTime).TotalSeconds,5:f1}s: {e.Data}");
stdoutSb.Append($"\n\t{(DateTime.Now - subprocessStartTime).TotalSeconds,5:f1}s: {e.Data}");
}
});

process.ErrorDataReceived += new DataReceivedEventHandler((s,e) =>
{
if (!string.IsNullOrEmpty(e.Data))
{
stderrSb.Append($"\n\t{(DateTime.Now - process.StartTime).TotalSeconds,5:f1}s: {e.Data}");
stderrSb.Append($"\n\t{(DateTime.Now - subprocessStartTime).TotalSeconds,5:f1}s: {e.Data}");
}
});

Expand Down