-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Support the Encoding enumeration in the Encoding Providers #37528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bce6ef4
Support the Encoding enumeration in the Encoding Providers
tarekgh 6c82451
Fix build
tarekgh 245f7f8
Fix netstandard build
tarekgh 9b1a91a
Address the feedback
tarekgh 173de50
More Feedback
tarekgh f0e05e9
More Feedback
tarekgh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 5 additions & 1 deletion
6
src/libraries/System.Text.Encoding.CodePages/ref/System.Text.Encoding.CodePages.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,13 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <Nullable>enable</Nullable> | ||
| <TargetFrameworks>netstandard2.0</TargetFrameworks> | ||
| <TargetFrameworks>$(NetCoreAppCurrent);netstandard2.0</TargetFrameworks> | ||
tarekgh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <Compile Include="System.Text.Encoding.CodePages.cs" /> | ||
| <Compile Include="System.Text.Encoding.CodePages.netcoreapp.cs" Condition="'$(TargetFramework)' == '$(NetCoreAppCurrent)'" /> | ||
| </ItemGroup> | ||
| <ItemGroup Condition="'$(TargetFramework)' == '$(NetCoreAppCurrent)'"> | ||
| <ProjectReference Include="../../System.Runtime/ref/System.Runtime.csproj" /> | ||
| </ItemGroup> | ||
| </Project> | ||
11 changes: 11 additions & 0 deletions
11
...libraries/System.Text.Encoding.CodePages/ref/System.Text.Encoding.CodePages.netcoreapp.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| namespace System.Text | ||
| { | ||
| public sealed partial class CodePagesEncodingProvider : System.Text.EncodingProvider | ||
| { | ||
| public override System.Collections.Generic.IEnumerable<System.Text.EncodingInfo> GetEncodings() { throw null; } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 60 additions & 0 deletions
60
...braries/System.Text.Encoding.CodePages/src/System/Text/BaseCodePageEncoding.netcoreapp.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using System.IO; | ||
| using System.Runtime.Serialization; | ||
| using System.Runtime.CompilerServices; | ||
|
|
||
| namespace System.Text | ||
| { | ||
| internal abstract partial class BaseCodePageEncoding : EncodingNLS, ISerializable | ||
| { | ||
| internal static unsafe EncodingInfo [] GetEncodings(CodePagesEncodingProvider provider) | ||
| { | ||
| lock (s_streamLock) | ||
| { | ||
| s_codePagesEncodingDataStream.Seek(CODEPAGE_DATA_FILE_HEADER_SIZE, SeekOrigin.Begin); | ||
|
|
||
| int codePagesCount; | ||
| fixed (byte* pBytes = &s_codePagesDataHeader[0]) | ||
| { | ||
| CodePageDataFileHeader* pDataHeader = (CodePageDataFileHeader*)pBytes; | ||
| codePagesCount = pDataHeader->CodePageCount; | ||
| } | ||
|
|
||
| EncodingInfo [] encodingInfoList = new EncodingInfo[codePagesCount]; | ||
|
|
||
| CodePageIndex codePageIndex = default; | ||
| Span<byte> pCodePageIndex = new Span<byte>(&codePageIndex, Unsafe.SizeOf<CodePageIndex>()); | ||
|
|
||
| for (int i = 0; i < codePagesCount; i++) | ||
| { | ||
| s_codePagesEncodingDataStream.Read(pCodePageIndex); | ||
|
|
||
| string codePageName; | ||
| switch (codePageIndex.CodePage) | ||
| { | ||
| // Fixup some encoding names. | ||
| case 950: codePageName = "big5"; break; | ||
| case 10002: codePageName = "x-mac-chinesetrad"; break; | ||
| case 20833: codePageName = "x-ebcdic-koreanextended"; break; | ||
| default: codePageName = new string(&codePageIndex.CodePageName); break; | ||
| } | ||
|
|
||
| string? resourceName = EncodingNLS.GetLocalizedEncodingNameResource(codePageIndex.CodePage); | ||
| string? displayName = null; | ||
|
|
||
| if (resourceName != null && resourceName.StartsWith("Globalization_cp_", StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| displayName = SR.GetResourceString(resourceName); | ||
| } | ||
|
|
||
| encodingInfoList[i] = new EncodingInfo(provider, codePageIndex.CodePage, codePageName, displayName ?? codePageName); | ||
| } | ||
|
|
||
| return encodingInfoList; | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.