Skip to content

Conversation

@stephentoub
Copy link
Member

Some of our full facades are missing <Nullable>enable</Nullable>. I don't think the lack of these causes any issues, but having them makes it easy to confirm what ref assemblies remain to be annotated.

Contributes to #2339
cc: @buyaa-n

@ghost
Copy link

ghost commented Jun 8, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@stephentoub stephentoub force-pushed the nullablefullfacades branch 2 times, most recently from e871d63 to bdbb489 Compare June 8, 2020 14:49
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stephentoub stephentoub force-pushed the nullablefullfacades branch from bdbb489 to 5c903f3 Compare June 8, 2020 19:52
Some of our full facades are missing `<Nullable>enable</Nullable>`.  I don't think the lack of these causes any issues, but having them makes it easy to confirm what ref assemblies remain to be annotated.
@stephentoub stephentoub force-pushed the nullablefullfacades branch from 5c903f3 to 73abb7f Compare June 9, 2020 00:13
@stephentoub stephentoub closed this Jun 9, 2020
@stephentoub stephentoub reopened this Jun 9, 2020
@stephentoub stephentoub merged commit 8d9c940 into dotnet:master Jun 9, 2020
@stephentoub stephentoub deleted the nullablefullfacades branch June 9, 2020 10:00
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants