Annotate System.Net.WebSockets.WebSocketProtocol for nullable reference types #37593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce types This also helped find that the annotation of WebSocketReceiveResult(..., string closeDescription) was wrong in the ref (it was correct in the src), so I fixed that.
|
Tagging subscribers to this area: @dotnet/ncl |
davidsh
approved these changes
Jun 8, 2020
Contributor
davidsh
left a comment
davidsh
left a comment
There was a problem hiding this comment.
LGTM. But there are still some nullable-related build errors.
buyaa-n
approved these changes
Jun 8, 2020
Contributor
buyaa-n
left a comment
buyaa-n
left a comment
There was a problem hiding this comment.
Left one NIT, overall looks good thanks!
JFYI: build failures on src\libraries\Common\src\System\Net\WebSockets\ManagedWebSocket.cs because Debug.Assert(...) not suppressing nullable warnings now
...aries/System.Net.WebSockets.WebSocketProtocol/ref/System.Net.WebSockets.WebSocketProtocol.cs
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also helped find that the annotation of
WebSocketReceiveResult(..., string? closeDescription)was wrong in the ref (it was correct in the src), so I fixed that.Contributes to #2339
cc: @buyaa-n, @davidsh