Initialize AsnEncodedData.RawData to empty array #37598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartonjs
added
the
breaking-change
bartonjs
approved these changes
Jun 8, 2020
Member
bartonjs
left a comment
bartonjs
left a comment
There was a problem hiding this comment.
I'm mildly hesitant; but the cases that throw now seem exceedingly rare compared to the cases that matter.
Maintains nullable annotation on RawData.
Member
Author
|
Ok. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintains nullable annotation on RawData.
Replaces #37572
@bartonjs, if you're not comfortable with the cases that became exceptional, I'm going to punt and let you fix it ;-)