Skip to content

Conversation

@tannergooding
Copy link
Member

This moves the ARM intrinsics out of System.Runtime.Intrinsics.Experimental and into the System.Runtime.Intrinsics project that ships in-box.

@tannergooding
Copy link
Member Author

@jkotas
Copy link
Member

jkotas commented Jun 9, 2020

Delete everything under System.Runtime.Intrinsics.Experimental ?

Copy link
Contributor

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. So will these APIs get automatically picked up by msdn and displayed here in next preview?

@tannergooding
Copy link
Member Author

Yes, they should.

I did a pass through all of the APIs and I didn't notice anything that we aren't already tracking via an issue.
It would likely be beneficial if someone else could do so as well.

@echesakov
Copy link
Contributor

I did a pass through all of the APIs and I didn't notice anything that we aren't already tracking via an issue.
It would likely be beneficial if someone else could do so as well.

I can do this

@BruceForstall
Copy link
Contributor

Love it!

@CarolEidt
Copy link
Contributor

Great Milestone!

Copy link
Contributor

@echesakov echesakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didn't see anything missing.

@TamarChristinaArm
Copy link
Contributor

Awesome! does this mean that everything will be in .NET 5? Including the multi-structure instructions?

@tannergooding
Copy link
Member Author

Awesome! does this mean that everything will be in .NET 5?

Everything that has been reviewed, approved, and implemented. There are still a few things that have been reviewed and approved but not implemented yet which are actively being worked on.

Including the multi-structure instructions?

These have not been reviewed/approved. My understanding is actual support would require work that likely won't be done for .NET 5.
The best we could do is expose the "correct" surface area and then emulate them with multiple individual loads until the actual support can be completed.

@TamarChristinaArm
Copy link
Contributor

Including the multi-structure instructions?

These have not been reviewed/approved. My understanding is actual support would require work that likely won't be done for .NET 5.
The best we could do is expose the "correct" surface area and then emulate them with multiple individual loads until the actual support can be completed.

Ah ok, yup that makes sense. Was just wondering :), Thanks all!

@tannergooding
Copy link
Member Author

@ericstj, @safern. Could one of you take a look at the allConfigurations failure:

F:\workspace_work\1\s\src\libraries\pkg\test\testPackages.proj(217,5): error : Validation Failed: Microsoft.Extensions.DependencyModel is harvesting assets from package version 3.1.4 which is not the latest for that package release. Latest package version from that release is 3.1.5. In order to fix this, run dotnet msbuild Microsoft.Extensions.DependencyModel.pkgproj /t:UpdateHarvestVersionOnPackageIndex /p:UpdateStablePackageInfo=true
##[error]src\libraries\pkg\test\testPackages.proj(217,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Validation Failed: Microsoft.Extensions.DependencyModel is harvesting assets from package version 3.1.4 which is not the latest for that package release. Latest package version from that release is 3.1.5. In order to fix this, run dotnet msbuild Microsoft.Extensions.DependencyModel.pkgproj /t:UpdateHarvestVersionOnPackageIndex /p:UpdateStablePackageInfo=true

I only removed the unrelated System.Runtime.Intrinsics.Experimental package and this is now showing up...

@jkotas
Copy link
Member

jkotas commented Jun 10, 2020

This should be fixed by #37663

@tannergooding
Copy link
Member Author

Thanks! It wasn't coming up in a search.

@tannergooding tannergooding merged commit 88297e2 into dotnet:master Jun 10, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
@tannergooding tannergooding deleted the arm-intrinsic branch November 11, 2022 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants