Port EventPipeBuffer, EventPipeBufferList, EventPipeBufferManager to Mono. #37756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lateralusX
force-pushed
the
lateralusX/eventpipe-buffer-manager
branch
2 times, most recently
from
70dc7b0 to
946f9e0
Compare
lateralusX
force-pushed
the
lateralusX/eventpipe-buffer-manager
branch
from
e55477d to
46233c6
Compare
lateralusX
changed the title
lambdageek
approved these changes
Jun 26, 2020
Member
lambdageek
left a comment
lambdageek
left a comment
There was a problem hiding this comment.
LGTM, although I did have a couple of questions.
lateralusX
force-pushed
the
lateralusX/eventpipe-buffer-manager
branch
from
46233c6 to
db9feef
Compare
lateralusX
requested review from
CoffeeFlux,
SamMonoRT,
akoeplinger,
alexischr,
kg,
marek-safar,
thaystg and
vargaz
as code owners
Member
|
(now disabled) WASM failure is due to #38573 |
…Mono. * Port EventPipeBuffer. * Port EventPipeBufferList. * Port EventPipeManager. * Merge internals source files. Changed GETTER_SETTER to only mandate use of inlined functions when calling betweeen source files for different types. Upgraded all use within each source file for direct struct access. * Changed function entry error checkin strategy. Only apply active checks on outer library API, ep.h, and use EP_ASSERT for all other functions. * Dropped requires_lock_held in function naming, switch to comment in header or in forward declare for functions that validates that lock is held. * Removed currently unused GETTER/SETTERS. * Moved more comments into sources from corresponding CoreCLR EventPipe sources. * Add EventPipeBuffer/EventPipeBufferManager unit tests. * Align to changes in native CoreCLR eventpipe* sources. * Add support starting default file session using env variables. * Disable eventpipe callback on WASM due to platform issues with delegates.
lateralusX
force-pushed
the
lateralusX/eventpipe-buffer-manager
branch
from
8df489a to
998e2ad
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #34600, adding BufferManager into the library including unit tests, merging source files and additional library restructuring.
Next step after this PR will be to enable a file session during runtime and add more unit tests and then start getting diagnostic server component over to Mono.