Skip to content

Fix tizen rootfs build#37891

Merged
janvorli merged 1 commit into
dotnet:masterfrom
gbalykov:fix-tizen-rootfs-build
Jun 15, 2020
Merged

Fix tizen rootfs build#37891
janvorli merged 1 commit into
dotnet:masterfrom
gbalykov:fix-tizen-rootfs-build

Conversation

@gbalykov
Copy link
Copy Markdown
Member

@gbalykov gbalykov commented Jun 15, 2020

Required after #37747

cc @alpencolt

@ghost
Copy link
Copy Markdown

ghost commented Jun 15, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

Copy link
Copy Markdown
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli janvorli merged commit 2799404 into dotnet:master Jun 15, 2020
@am11
Copy link
Copy Markdown
Member

am11 commented Jun 15, 2020

It's best to push the change upstream (dotnet/arcade), otherwise anything under eng/common will be overwritten with the next arcade update.

ps: perhaps, it would be a good idea to add a git-push hook to notify users for such things.

@gbalykov
Copy link
Copy Markdown
Member Author

@am11 thanks for information, I'll open PR to arcade

@janvorli
Copy link
Copy Markdown
Member

Oops, I haven't noticed it didn't go to arcade, let me revert this change here.

janvorli added a commit that referenced this pull request Jun 15, 2020
jkotas pushed a commit that referenced this pull request Jun 15, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants