Disable GenericArraySortHelperTest to fix CI#37997
Merged
Merged
Conversation
eerhardt
approved these changes
Jun 16, 2020
Member
|
Thanks! Sorry for the trouble. You will probably want to use |
Member
Author
|
Merging to unblock CI on other PRs as well as Rolling. I'll put up a subsequent PR that will fix the version of the linker we use in our tests to match latest we use in the rest of the repo. |
safern
approved these changes
Jun 16, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right before I merged the PR that added this test, @sbomer merged his PR #37780 which renamed all Linker attributes we had, and our linker test infra currently uses the linker that comes with the SDK which doesn't understand these new attributes yet, so the test has naturally started failing now. This PR will disable the test for now to unblock CI and rolling while I fix the infra to use the latest linker so that we can understand these new attributes in our tests.
cc: @eerhardt @layomia @safern