Pipeline fixes

[trylek]

No description provided.

[ViktorHofer]

Feel free to merge whenever this is ready. Thanks.

[trylek]

OK, I'll merge it in now to unblock the lab by canceling the run. It's of no use really as it doesn't exercise the template at all, I ran the appropriate pipeline separately ;-).

[trylek]

I just love looking at the passing jobs in the PR pipeline...

[trylek]

I see some failures in the installer pipeline I'm not yet too familiar with - @jkoritzinsky / @dagood, can you please assess whether these are expected or potentially caused by a bug in Viktor's change?

[dagood]

Sure, but I can't find the pipeline, can you link send a link?

[trylek]

https://dev.azure.com/dnceng/public/_build/results?buildId=427664

[trylek]

Thank you!

[trylek]

Hmm, no idea why I initiated this chat on the grave of my closed PR, maybe attributable either to my overall senility or the stress of the last three weeks ;-).

[dagood]

Thanks, was looking in internal rather than public. 🙂

This is the known issue in email thread "Heads up: Pdb2pdb errors as of latest Arcade update", they're working on a fix (the email doesn't mention an issue that I can link to though @riarenas):

  Unrecognized option: '/verbose'
F:\workspace.1\_work\1\s\.packages\microsoft.dotnet.arcade.sdk\5.0.0-beta.19563.9\tools\SymStore.targets(60,5): error MSB3073: The command ""F:\workspace.1\_work\1\s\.packages\microsoft.diasymreader.pdb2pdb\1.1.0-beta2-19521-03\tools\Pdb2Pdb.exe" "F:\workspace.1\_work\1\s\artifacts\bin\Microsoft.DotNet.PlatformAbstractions\Release\net45\Microsoft.DotNet.PlatformAbstractions.dll" /out "F:\workspace.1\_work\1\s\artifacts\SymStore\Release\Microsoft.DotNet.PlatformAbstractions\net45\Microsoft.DotNet.PlatformAbstractions.pdb" /verbose /srcsvrvar SRC_INDEX=public" exited with code 1. [F:\workspace.1\_work\1\s\src\installer\managed\Microsoft.DotNet.PlatformAbstractions\Microsoft.DotNet.PlatformAbstractions.csproj]

Looks like the same thing in all the legs I checked.

[trylek]

Thanks Davis. I guess that in combination with the other assessments we're coming to the conclusion that Viktor's change is fine and we can merge it in. As usual CoreCLR seems to be the long pole so I guess I should wait for a bit to achieve a higher level of confidence but I think I feel confident to push the merge button on Viktor's change.