Port type system tests from CoreRT repo #38128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`build.cmd -test -s clr.tools -rc checked -a x64` builds the product and unit tests, and then runs the unit tests.
Member
jkoritzinsky
left a comment
jkoritzinsky
left a comment
There was a problem hiding this comment.
Just one question from me. Other than that, if this works to run the tests locally then it looks good to me.
jkotas
reviewed
Jun 19, 2020
src/coreclr/src/tools/aot/ILCompiler.TypeSystem.ReadyToRun.Tests/TestTypeSystemContext.cs
Outdated
Show resolved
Hide resolved
Adds back another 5 passing tests
MichalStrehovsky
approved these changes
Jun 22, 2020
Member
MichalStrehovsky
left a comment
MichalStrehovsky
left a comment
There was a problem hiding this comment.
Looks good otherwise, thank you!
src/coreclr/src/tools/aot/ILCompiler.TypeSystem.ReadyToRun.Tests/TestTypeSystemContext.cs
Outdated
Show resolved
Hide resolved
On Alpine x64, ildasm executable cannot be found. The Ilasm SDK seems to be missing linux-musl recognition in its targets: https://github.com/dotnet/runtime/blob/54625f377552300ce03100b4d1689af30395f9fd/src/coreclr/src/.nuget/Microsoft.NET.Sdk.IL/targets/Microsoft.NET.Sdk.IL.targets#L32
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port the managed type system unit tests and wire them up to
build.cmd -testso they run if theclr.toolssubset is included in compilation. We're missing USG support so those tests are disabled. Similarly, the tests for interfaces on arrays don't work in this repo since we never ported theArray<T>weirdo functionality.The first commit is a simple xcopy, and subsequent commits make the tests work in this repo. Currently these are not enabled in CI and I could use some advice there since as I understand the plan is to add Pri 0 tests to
build -testfor the coreclr partition in the future. If we just have fast running unit tests then I'd be okay with these running as part of the product build when the coreclr partition has changes. Or we could build / run them as part of the test build.Implements issue #200
cc @dotnet/crossgen-contrib