Skip to content

Add GCStress testing for libraries tests on checked CoreCLR #38235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BruceForstall merged 4 commits into from
Jul 10, 2020
Merged

Add GCStress testing for libraries tests on checked CoreCLR #38235

BruceForstall merged 4 commits into from
Jul 10, 2020

Conversation

@BruceForstall
Copy link
Contributor

@BruceForstall BruceForstall commented Jun 22, 2020 •
edited
Loading

Part of this is downloading and copying the stress dependencies (namely, coredistools) into the
testhost.

There are still many issues to address with failures in these tests, so the schedule
is disabled.

Disable GCStress0x3 for now, as that causes many timeouts in these tests.

Fixes #38233

@Dotnet-GitSync-Bot
Copy link
Collaborator

Dotnet-GitSync-Bot commented Jun 22, 2020

I couldn't figure out the best area label to add to this PR. Please help me learn by adding exactly one area label.

@BruceForstall BruceForstall marked this pull request as draft June 22, 2020 22:45
@BruceForstall

This comment has been minimized.

Sign in to view
@BruceForstall

This comment has been minimized.

Sign in to view
@jaredpar jaredpar mentioned this pull request Jun 23, 2020
Closed
@BruceForstall BruceForstall force-pushed the LibrariesTestsForCoreClrAddGCStress2 branch from 5ae7c1d to a0a379b Compare June 27, 2020 19:44
@BruceForstall

This comment has been minimized.

Sign in to view
@BruceForstall BruceForstall force-pushed the LibrariesTestsForCoreClrAddGCStress2 branch from a0a379b to 6b18fa0 Compare June 28, 2020 03:37
@BruceForstall

This comment has been minimized.

Sign in to view
@BruceForstall BruceForstall marked this pull request as ready for review June 29, 2020 01:11
@BruceForstall
Copy link
Contributor Author

BruceForstall commented Jun 29, 2020

Triggered runtime-coreclr libraries-gcstress0x3-gcstress0xc: https://dev.azure.com/dnceng/public/_build/results?buildId=708812&view=results

@BruceForstall BruceForstall requested review from jashook and trylek July 2, 2020 21:57
@BruceForstall
Copy link
Contributor Author

BruceForstall commented Jul 2, 2020

ping

can anyone take a look?

@BruceForstall
Copy link
Contributor Author

BruceForstall commented Jul 7, 2020

ping

Maybe someone on @dotnet/jit-contrib can sign off?

safern
safern reviewed Jul 7, 2020
View reviewed changes
eng/pipelines/libraries/run-test-job.yml Outdated
Copy link
Member

@safern safern Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we link this to an issue?

Copy link
Contributor Author

@BruceForstall BruceForstall Jul 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. I'll add one.

safern
safern reviewed Jul 7, 2020
View reviewed changes
src/libraries/sendtohelixhelp.proj Outdated
Copy link
Member

@safern safern Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use $(Scenario.StartsWith('gcstress')) or '$(Scenario)' == 'heapverify1'?

Copy link
Contributor Author

@BruceForstall BruceForstall Jul 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to leave it explicit, even through it is more verbose, as it makes it easier to 'grep' for a full scenario name and find every file that references it.

@safern
Copy link
Member

safern commented Jul 7, 2020

Sorry I missed this. Just reviewed.

echesakov
echesakov reviewed Jul 7, 2020
View reviewed changes
src/coreclr/tests/setup-stress-dependencies.sh Outdated
Copy link
Contributor

@echesakov echesakov Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit,

    echo "$0 --arch=<TargetArch> --outputDir=<coredistools_lib_install_path>"

@BruceForstall BruceForstall mentioned this pull request Jul 8, 2020
Closed
@BruceForstall
Add GCStress testing for libraries tests on checked CoreCLR
0bb0c96 
Disable GCStress0x3 for now, as that causes many timeouts in
these tests.
@BruceForstall
Increase timeout for GCStress scenarios
93a126b
@BruceForstall
Disable scheduled runs for libraries gcstress runs
817adc7 
There are currently too many failures in these jobs
so we don't want to run them on a schedule yet.
@BruceForstall
Add tracking issue for disabling GCStress=3
9bdf668
@BruceForstall BruceForstall force-pushed the LibrariesTestsForCoreClrAddGCStress2 branch from d5c7565 to 9bdf668 Compare July 8, 2020 01:26
@BruceForstall
Copy link
Contributor Author

BruceForstall commented Jul 10, 2020

Any final objections? Or sign-off?

trylek
trylek approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Bruce for making these improvements!

@BruceForstall BruceForstall merged commit c4dfc54 into dotnet:master Jul 10, 2020
@BruceForstall BruceForstall deleted the LibrariesTestsForCoreClrAddGCStress2 branch July 10, 2020 23:59
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@trylek trylek trylek approved these changes

@safern safern safern approved these changes

@ViktorHofer ViktorHofer Awaiting requested review from ViktorHofer

@jashook jashook Awaiting requested review from jashook

+1 more reviewer

@echesakov echesakov echesakov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Infrastructure-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add GCStress testing AzDO pipelines for libraries tests against coreclr

5 participants

@BruceForstall @Dotnet-GitSync-Bot @safern @echesakov @trylek