Skip to content

Conversation

@mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Jun 26, 2020

This PR looks to re-enable the following test suites for WebAssembly now that they pass/skip:

@ghost
Copy link

ghost commented Jun 26, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@safern
Copy link
Member

safern commented Jun 26, 2020

System.TypeInitializationException : The type initializer for 'System.Runtime.Serialization.Formatters.Binary.Converter' threw an exception.\n---- System.IO.FileNotFoundException :

There is one test failure in System.Threading.Channels.Tests.

I'm taking a look at those kind of failures which are impacting like 200 tests.

@steveisok
Copy link
Member

@safern, @akoeplinger thinks it might be mscorlib being excluded in the WasmAppBuilder.

@safern
Copy link
Member

safern commented Jun 26, 2020

Yes that seems the most likely reason.

@akoeplinger
Copy link
Member

@mdh1418 can you please open an issue for the System.Runtime.Serialization.Formatters.Binary.Converter so we can disable it with an ActiveIssue for now in this PR?

@safern
Copy link
Member

safern commented Jun 26, 2020

We can disable against: #37648 -- I'm using that to fix those remainders of FileNotFoundException.

@mdh1418
Copy link
Member Author

mdh1418 commented Jun 26, 2020

The issue for System.Runtime.Serialization.Formatters.Binary.Converter is here #38443

@safern
Copy link
Member

safern commented Jun 26, 2020

@mdh1418 let's please disable against the issue I posted above and close the other issue, since this failure is happening in all tests that use serialization, not just in this one.

@lewing lewing merged commit 29dee27 into dotnet:master Jun 27, 2020
@mdh1418 mdh1418 deleted the mdhwang/reenable_system_threading_tasks_and_channels branch July 23, 2020 13:37
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants