crossgen2 fixes and cleanup #38463
crossgen2 fixes and cleanup #38463
Conversation
- Delete copy&paste code from CoreCLR that is only relevant for IL verification - Delete early out for CORINFO_ACCESS_ADDRESS. There is no check like that in old crossgen. Reduces number of methods that fail to compile in CoreLib significantly. - Ship internal calls without throwing and catching exceptions. Fixes dotnet#32663
|
cc @dotnet/crossgen-contrib Factored out from #38229 |
trylek
left a comment
trylek
left a comment
There was a problem hiding this comment.
Looks great, thanks for cleaning this up!
davidwrighton
left a comment
davidwrighton
left a comment
There was a problem hiding this comment.
Please hold off on this for a day or two. I want to write up a test around the address stuff to make sure that it isn't broken in some odd way. There is code in zapinfo.cpp which checks for CORINFO_FIELD_STATIC_ADDRESS and skips codegen (see ZapInfo::getFieldInfo) I agree though that the current logic is way too broad.
|
I looked a little deeper, and you are right. That logic doesn't apply. We probably needed to disable the address handling due to incorrect layout, not any other reason. This is another reason to write that stress mode that I've been harping about where we can verify that layout in the runtime matches that of crossgen2. In fact, I'm going to write that instead of tests for these particular issues. |
ghost
locked as resolved and limited conversation to collaborators
4 participants
Fixes #32663