Skip to content

Add examples of System.Private.CoreLib iterative workflow #38885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
safern merged 3 commits into from
Jul 7, 2020
Merged

Add examples of System.Private.CoreLib iterative workflow #38885

safern merged 3 commits into from
Jul 7, 2020

Conversation

@safern
Copy link
Member

@safern safern commented Jul 7, 2020

cc: @danmosemsft @stephentoub

@Dotnet-GitSync-Bot
Copy link
Collaborator

Dotnet-GitSync-Bot commented Jul 7, 2020

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@safern
Copy link
Member Author

safern commented Jul 7, 2020

Oops, missed to update build.sh, will update that.

danmoseley
danmoseley reviewed Jul 7, 2020
View reviewed changes
danmoseley
danmoseley reviewed Jul 7, 2020
View reviewed changes
danmoseley
danmoseley reviewed Jul 7, 2020
View reviewed changes
stephentoub
stephentoub approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than Dan's comments, LGTM. Thanks.

@ViktorHofer
Copy link
Member

ViktorHofer commented Jul 7, 2020 •
edited
Loading

FWIW we should start binplacing CoreLib (and optionally crossgen it) so that these manual steps aren't necessary. cc @ericstj

Related #38034

@safern
Copy link
Member Author

safern commented Jul 7, 2020

FWIW we should start binplacing CoreLib (and optionally crossgen it) so that these manual steps aren't necessary

We should be careful when doing that because if CoreLib is built via a P2P and the configuration for CoreLib is Debug, but the runtime was built in release, there will be a configuration miss match in between CoreLib and runtime and I believe that is not allowed.

@ViktorHofer
Copy link
Member

ViktorHofer commented Jul 7, 2020

configuration miss match in between CoreLib and runtime and I believe that is not allowed.

@jkotas is mixing configurations between the runtime and CoreLib problematic? I assume not...

@safern safern merged commit 792fd1d into dotnet:master Jul 7, 2020
@safern safern deleted the CoreLibIterativeExample branch July 7, 2020 20:19
@jkotas
Copy link
Member

jkotas commented Jul 7, 2020

@jkotas is mixing configurations between the runtime and CoreLib problematic?

Yes, it is problematic. Layout of some data structures embedded in CoreLib is different between debug and release.

@safern safern mentioned this pull request Aug 4, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub approved these changes

@danmoseley danmoseley danmoseley approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@safern @Dotnet-GitSync-Bot @ViktorHofer @jkotas @stephentoub @danmoseley