Fix remaining license headers#38953
Merged
stephentoub merged 13 commits intodotnet:masterfrom Jul 9, 2020
Merged
Conversation
stephentoub
requested review from
BrzVlad,
CoffeeFlux,
EgorBo,
SamMonoRT,
akoeplinger,
alexischr,
jozkee,
lambdageek,
layomia,
marek-safar,
steveharter,
steveisok,
thaystg and
vargaz
as code owners
|
Tagging subscribers to this area: @dotnet/ncl |
jkotas
approved these changes
Jul 8, 2020
Tratcher
reviewed
Jul 9, 2020
| @@ -75,7 +74,7 @@ internal enum Http3ErrorCode : long | |||
| RequestCancelled = 0x10c, | |||
| /// <summary> | |||
| /// H3_REQUEST_INCOMPLETE (0x10E): | |||
| /// The client’s stream terminated without containing a fully-formed request. | |||
| /// The client?s stream terminated without containing a fully-formed request. | |||
Member
There was a problem hiding this comment.
Something odd happened to the file encoding here?
Member
Author
There was a problem hiding this comment.
Grr, I thought I caught all of those. It should just be ' rather than a smart tick.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #38793 tweaked the license header on ~30K files, this cleans up after it, handling another ~1300, and adding license headers where they were missing in .cs files under libraries. It also adds a default license header to the .editorconfig.
cc: @jkotas