Skip to content

WASM Re-enable Threading.Channels serialization tests #39016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
safern merged 3 commits into from
Jul 10, 2020
Merged

WASM Re-enable Threading.Channels serialization tests #39016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e37b7ef
WASM Re-enable Threading.Channels serialization tests
safern Jul 9, 2020
9892769
PR Feedback
safern Jul 9, 2020
a02621d
Use ConditionalFact
safern Jul 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ public static partial class PlatformDetection
public static bool IsNotWindows => !IsWindows;

public static bool IsThreadingSupported => !IsBrowser;
public static bool IsBinaryFormatterSupported => !IsBrowser;

// Please make sure that you have the libgdiplus dependency installed.
// For details, see https://docs.microsoft.com/dotnet/core/install/dependencies?pivots=os-macos&tabs=netcore31#libgdiplus
public static bool IsDrawingSupported
Expand Down
3 changes: 1 addition & 2 deletions src/libraries/System.Threading.Channels/tests/ChannelClosedExceptionTests.netcoreapp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ namespace System.Threading.Channels.Tests
{
public partial class ChannelClosedExceptionTests
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/37648", TestPlatforms.Browser)]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsBinaryFormatterSupported))]
public void Serialization_Roundtrip()
{
var s = new MemoryStream();
Expand Down