Remove cross targeting for TraceSource and TextWriterTraceListener #39043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
stephentoub
approved these changes
Jul 9, 2020
ViktorHofer
reviewed
Jul 9, 2020
| <Compile Include="System\Diagnostics\SwitchLevelAttribute.cs" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <Reference Include="System.Collections.NonGeneric" /> |
Member
There was a problem hiding this comment.
why are you removing the P2Ps?
Contributor
Author
There was a problem hiding this comment.
I reverted all but system.io.filesystem bcoz it doesnt have any ridless tfm
Member
There was a problem hiding this comment.
I'm fine if you want to switch to named references (it makes sense for shared framework parts) but I just wanted to understand the reason for this change.
ViktorHofer
reviewed
Jul 9, 2020
src/libraries/System.Diagnostics.TraceSource/tests/System.Diagnostics.TraceSource.Tests.csproj
Show resolved
Hide resolved
ericstj
approved these changes
Jul 9, 2020
stephentoub
reviewed
Jul 9, 2020
src/libraries/System.Diagnostics.TraceSource/src/System.Diagnostics.TraceSource.csproj
Show resolved
Hide resolved
ViktorHofer
approved these changes
Jul 10, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR #38908