Skip to content

[wasm] Addressing System.Runtime.InteropServices.RuntimeInformation.Tests failures #39073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akoeplinger merged 2 commits into from
Jul 10, 2020
Merged

[wasm] Addressing System.Runtime.InteropServices.RuntimeInformation.Tests failures #39073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48dd09e
[wasm] Addressing System.Runtime.InteropServices.RuntimeInformation.T…
Jul 10, 2020
7785ab4
[wasm] Removed System.Runtime.InteropServices.RuntimeInformation from…
Jul 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...braries/System.Runtime.InteropServices.RuntimeInformation/tests/CheckArchitectureTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ public void VerifyArchitecture()
Assert.Equal(IntPtr.Size == 4 ? Architecture.Arm : Architecture.Arm64, processArch);
break;

case Architecture.Wasm:
Assert.Equal(Architecture.Wasm, processArch);
break;

default:
Assert.False(true, "Unexpected Architecture.");
break;
Expand Down
1 change: 1 addition & 0 deletions ...libraries/System.Runtime.InteropServices.RuntimeInformation/tests/DescriptionNameTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ namespace System.Runtime.InteropServices.RuntimeInformationTests
public class DescriptionNameTests
{
[Fact]
[PlatformSpecific(~TestPlatforms.Browser)] // throws PNSE when binariesLocation is not an empty string.
public void DumpRuntimeInformationToConsole()
{
// Not really a test, but useful to dump a variety of information to the test log to help
Expand Down
1 change: 1 addition & 0 deletions ...braries/System.Runtime.InteropServices.RuntimeInformation/tests/RuntimeIdentifierTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ namespace System.Runtime.InteropServices.RuntimeInformationTests
public class RuntimeIdentifierTests
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/39074", TestPlatforms.Browser)]
public void VerifyOSRid()
{
Assert.NotNull(RuntimeInformation.RuntimeIdentifier);
Expand Down
1 change: 0 additions & 1 deletion src/libraries/tests.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Resources.Reader\tests\System.Resources.Reader.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Resources.ResourceManager\tests\System.Resources.ResourceManager.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.Extensions\tests\System.Runtime.Extensions.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.InteropServices.RuntimeInformation\tests\System.Runtime.InteropServices.RuntimeInformation.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.InteropServices\tests\System.Runtime.InteropServices.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.Loader\tests\DefaultContext\System.Runtime.Loader.DefaultContext.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.Loader\tests\System.Runtime.Loader.Tests.csproj" />
Expand Down