Fix creating OperatingSystem with PlatformID.Other #39130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating an OperatingSystem with PlatformID.Other would result in an exception about an unexpected enum value. dotnet#38790 was missing some tests that verified this behavior.
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
stephentoub
reviewed
Jul 11, 2020
Member
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
Is there a test validating that other is returned on browser?
Member
Author
|
@stephentoub there was one in System.Runtime.Extensions and it was actually failing but we're not running it on CI until #38996 is merged. I fixed it to verify the expected value and tested locally. |
akoeplinger
force-pushed
the
fix-platformid-other
branch
from
1e101d6 to
a92304e
Compare
stephentoub
approved these changes
Jul 11, 2020
eerhardt
reviewed
Jul 12, 2020
| case PlatformID.Unix: os = "Unix "; break; | ||
| case PlatformID.Xbox: os = "Xbox "; break; | ||
| case PlatformID.MacOSX: os = "Mac OS X "; break; | ||
| case PlatformID.Other: os = "Other"; break; |
Member
There was a problem hiding this comment.
Does this need a space after it? The others have a space before the version.
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
Jul 13, 2020
akoeplinger
added a commit
that referenced
this pull request
Jul 13, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating an OperatingSystem with PlatformID.Other would result in an exception about an unexpected enum value.
#38790 was missing some tests that verified this behavior.