Skip to content

WASM: Disable thread related tests on System.IO.Compression #39231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akoeplinger merged 1 commit into from
Jul 14, 2020
Merged

WASM: Disable thread related tests on System.IO.Compression #39231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/libraries/Common/tests/System/IO/Compression/CompressionStreamUnitTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public abstract class CompressionStreamUnitTestBase : CompressionStreamTestBase
{
private const int TaskTimeout = 30 * 1000; // Generous timeout for official test runs

[Fact]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
Copy link
Member

@stephentoub stephentoub Jul 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the issue here is the blocking, these tests could be made to work; there just wasn't a reason to avoid the blocking previously.

How do we want to track the difference between "this test can never work with wasm" and "this test doesn't currently work with wasm but could be made to"?

Copy link
Member Author

@akoeplinger akoeplinger Jul 14, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My plan was to do a pass over all the PlatformDetection.IsThreadingSupported items once we have more capacity to actually analyze/rewrite the tests. Right now the focus is on getting as much coverage up as possible for preview8.

public virtual void FlushAsync_DuringWriteAsync()
{
if (FlushNoOps)
Expand Down Expand Up @@ -49,7 +49,7 @@ public virtual void FlushAsync_DuringWriteAsync()
}
}

[Fact]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
public async Task FlushAsync_DuringReadAsync()
{
if (FlushNoOps)
Expand Down Expand Up @@ -78,7 +78,7 @@ public async Task FlushAsync_DuringReadAsync()
}
}

[Fact]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
public async Task FlushAsync_DuringFlushAsync()
{
if (FlushNoOps)
Expand Down Expand Up @@ -121,7 +121,7 @@ public async Task FlushAsync_DuringFlushAsync()
}
}

[Fact]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
public virtual void WriteAsync_DuringWriteAsync()
{
byte[] buffer = new byte[100000];
Expand Down Expand Up @@ -154,7 +154,7 @@ public virtual void WriteAsync_DuringWriteAsync()
}
}

[Fact]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
public async Task ReadAsync_DuringReadAsync()
{
byte[] buffer = new byte[32];
Expand All @@ -179,7 +179,7 @@ public async Task ReadAsync_DuringReadAsync()
}
}

[Fact]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
public virtual async Task Dispose_WithUnfinishedReadAsync()
{
string compressedPath = CompressedTestFile(UncompressedTestFile());
Expand Down
1 change: 0 additions & 1 deletion src/libraries/tests.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Globalization.Calendars\tests\System.Globalization.Calendars.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Globalization.Extensions\tests\System.Globalization.Extensions.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Globalization\tests\System.Globalization.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.IO.Compression\tests\System.IO.Compression.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.IO.FileSystem.DriveInfo\tests\System.IO.FileSystem.DriveInfo.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.IO.FileSystem\tests\System.IO.FileSystem.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.IO.MemoryMappedFiles\tests\System.IO.MemoryMappedFiles.Tests.csproj" />
Expand Down