Fix issue with Trimming tests on Windows #39307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safern
approved these changes
Jul 14, 2020
stephentoub
approved these changes
Jul 14, 2020
eerhardt
reviewed
Jul 14, 2020
eerhardt
approved these changes
Jul 15, 2020
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
LGTM. Thanks for digging into this.
Member
Author
|
Failures are unrelated, so merging this. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39288
RuntimeList.xml file was incorrectly also listing .pdbs so this PR is fixing that and will fix the issue that caused the tests to be disabled.
cc: @eerhardt @marek-safar @safern @ViktorHofer