Fix up trimming tests for new SDK #39334
Conversation
Now that we have a new SDK with the latest linker settings, we need to change how we invoke the linker during the trimming tests.
|
Tagging subscribers to this area: @safern, @ViktorHofer |
|
The linker-tests are passing, which this change only affects them. The test failure for Threading.Tasks.Parallel is unrelated. |
joperezr
left a comment
joperezr
left a comment
There was a problem hiding this comment.
LGTM. I believe that means we now are not really waiting for any new updates in terms of SDK right as we have merged the other changes on the properties or am I missing something?
|
The other linker properties got fixed with #39158 - when the new SDK came into the branch.
As far as I know, we should be hooked up with all the latest linker and SDK changes. With this change, I made a deliberate failure in my linking test, ran it and saw the failure locally. So I think we are running the linker correctly now. |
ghost
locked as resolved and limited conversation to collaborators
5 participants
Now that we have a new SDK with the latest linker settings, we need to change how we invoke the linker during the trimming tests.
See #39126 and #39158 which came in hours apart. Fixing the conflict that occurred between them.