Skip to content

Reenable gcdump test #39555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davmason merged 3 commits into from
Jul 20, 2020
Merged

Reenable gcdump test #39555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62cbf12
Revert "Disable eventpipe/gcdump test against #39361 (#39362)"
davmason Jul 17, 2020
e168fc4
lower gcdump thresholds
davmason Jul 17, 2020
5f74e23
Update src/tests/tracing/eventpipe/gcdump/gcdump.cs
danmoseley Jul 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/coreclr/tests/issues.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@
<ExcludeList Include="$(XunitTestBinBase)/tracing/tracecontrol/tracecontrol/*">
<Issue>https://github.com/dotnet/runtime/issues/11204</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/tracing/eventpipe/gcdump/gcdump/*">
<Issue>https://github.com/dotnet/runtime/issues/39361</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/readytorun/DynamicMethodGCStress/DynamicMethodGCStress/*">
<Issue>timeout</Issue>
</ExcludeList>
Expand Down
22 changes: 10 additions & 12 deletions src/tests/tracing/eventpipe/gcdump/gcdump.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,17 +82,15 @@ public static int Main(string[] args)

return () =>
{
// These values are ~80% (rounded to nice whole numbers) of the values
// I saw when writing the test. The idea is that I want to catch
// any real deviation in the number of types, but don't want to have
// to maintain this test as the number of types varies. (And they will vary due to
// framework code changes). If this test needs any sort of ongoing maintenance
// just change all these values to a low number like 10 and move on.
if (_bulkTypeCount > 125
&& _bulkNodeCount > 600
&& _bulkEdgeCount > 850
&& _bulkRootEdgeCount > 250
&& _bulkRootStaticVarCount > 70)
// Hopefully it is low enough to be resilient to changes in the runtime
// and high enough to catch issues. There should be between hundreds and thousands
// for each, but the number is variable and the point of the test is to verify
// that we get any events at all.
if (_bulkTypeCount > 50
&& _bulkNodeCount > 50
&& _bulkEdgeCount > 50
&& _bulkRootEdgeCount > 50
&& _bulkRootStaticVarCount > 50)
{
return 100;
}
Expand All @@ -108,4 +106,4 @@ public static int Main(string[] args)
};
};
}
}
}