Skip to content

[wasm] Enable System.ComponentModel.TypeConverter test suite #39710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akoeplinger merged 1 commit into from
Jul 21, 2020
Merged

[wasm] Enable System.ComponentModel.TypeConverter test suite #39710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .../Security/Authentication/ExtendedProtection/ExtendedProtectionPolicyTypeConverterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,14 @@ public void CanConvertTo_PositiveTests()
}

[Fact]
[PlatformSpecific(~TestPlatforms.Browser)] // System.Net.Security is not supported on this platform.
public void ConvertTo_NullTypeTests()
{
Assert.Throws<ArgumentNullException>(() => converter.ConvertTo(null, CultureInfo.InvariantCulture, new ExtendedProtectionPolicy(PolicyEnforcement.Never), null));
}

[Fact]
[PlatformSpecific(~TestPlatforms.Browser)] // System.Net.Security is not supported on this platform.
public void ConvertTo_PositiveTests()
{
ExtendedProtectionPolicy policy = new ExtendedProtectionPolicy(PolicyEnforcement.Never);
Expand All @@ -55,6 +57,7 @@ public void ConvertTo_PositiveTests()
}

[Theory]
[PlatformSpecific(~TestPlatforms.Browser)] // System.Net.Security is not supported on this platform.
[InlineData(typeof(int))]
[InlineData(typeof(ExtendedProtectionPolicy))]
[InlineData(typeof(bool))]
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.ComponentModel.TypeConverter/tests/XTypeDescriptionProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

namespace System.Xml.Linq.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/39709", TestPlatforms.Browser)]
public class XTypeDescriptionProviderTests
{
[Fact]
Expand Down
1 change: 0 additions & 1 deletion src/libraries/tests.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@

<ItemGroup Condition="'$(TargetOS)' == 'Browser' and '$(RunDisabledWasmTests)' != 'true'">
<!-- Builds currently do not pass -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.ComponentModel.TypeConverter\tests\System.ComponentModel.TypeConverter.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Data.Common\tests\System.Data.Common.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Diagnostics.DiagnosticSource\tests\TestWithConfigSwitches\System.Diagnostics.DiagnosticSource.Switches.Tests.csproj" />

Expand Down