Skip to content

Update the JITEEVersionIdentifier #39779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tannergooding merged 1 commit into from
Jul 22, 2020
Merged

Update the JITEEVersionIdentifier #39779

tannergooding merged 1 commit into from
Jul 22, 2020

Conversation

@tannergooding
Copy link
Member

@tannergooding tannergooding commented Jul 22, 2020

As per #39777, #38460 should have updated the JITEEVersionIdentifier but did not. The last update was 25 days ago so this ensures it is updated.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 22, 2020
@tannergooding
Copy link
Member Author

tannergooding commented Jul 22, 2020

CC. @jkotas, @MichalStrehovsky

@tannergooding
Copy link
Member Author

tannergooding commented Jul 22, 2020

Does this need to be backported to the preview 8 branch as well?

@tannergooding tannergooding merged commit 19e4e45 into dotnet:master Jul 22, 2020
@MichalStrehovsky
Copy link
Member

MichalStrehovsky commented Jul 23, 2020

Thanks!

Does this need to be backported to the preview 8 branch as well?

Probably not. The chances someone hits it there are probably low.

@BruceForstall
Copy link
Contributor

BruceForstall commented Jul 23, 2020

Please tag @dotnet/jit-contrib on JIT-EE interface GUID changes. Thanks.

@JulieLeeMSFT
Copy link
Member

JulieLeeMSFT commented Jul 23, 2020

Does this change require JIT side change?

@BruceForstall
Copy link
Contributor

BruceForstall commented Jul 23, 2020

Does this change require JIT side change?

no

@jkotas
Copy link
Member

jkotas commented Jul 23, 2020

Please tag @dotnet/jit-contrib on JIT-EE interface GUID changes.

I have submitted #39862 to make this automatic

@BruceForstall
Copy link
Contributor

BruceForstall commented Jul 23, 2020

I have submitted #39862 to make this automatic

Very cool! I didn't know that was a thing.

Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@tannergooding @Jacksondr5
Update the JITEEVersionIdentifier (dotnet#39779)
3d62a91
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
@tannergooding tannergooding deleted the update-jitee branch July 1, 2025 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotas jkotas jkotas approved these changes

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@tannergooding @MichalStrehovsky @BruceForstall @JulieLeeMSFT @jkotas @karelz @Dotnet-GitSync-Bot