Skip to content

[mono] Fix warnings on OSX netcore #39997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CoffeeFlux merged 1 commit into from
Jul 28, 2020
Merged

[mono] Fix warnings on OSX netcore #39997

CoffeeFlux merged 1 commit into from
Jul 28, 2020

Conversation

@CoffeeFlux
Copy link
Contributor

@CoffeeFlux CoffeeFlux commented Jul 28, 2020

This commit brings us back to zero warnings for the default build configuration.

@CoffeeFlux CoffeeFlux requested review from lateralusX and thaystg July 28, 2020 09:53
@CoffeeFlux CoffeeFlux requested a review from akoeplinger July 28, 2020 09:55
@ghost
Copy link

ghost commented Jul 28, 2020

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

@monojenkins monojenkins mentioned this pull request Jul 28, 2020
Merged
@akoeplinger
Copy link
Member

akoeplinger commented Jul 28, 2020

/azp run runtime

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 28, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@akoeplinger
Copy link
Member

akoeplinger commented Jul 28, 2020

@CoffeeFlux looks like this causes a build failure on the Windows build:

  F:\workspace\_work\1\s\src\mono\mono\metadata\mono-config.c(695,93): error C4047: '=': 'char' differs in levels of indirection from 'gchar *' [F:\workspace\_work\1\s\src\mono\msvc\libmono-dynamic.vcxproj]
  F:\workspace\_work\1\s\src\mono\mono\metadata\mono-config.c(696,61): error C4047: 'function': 'const char *' differs in levels of indirection from 'char' [F:\workspace\_work\1\s\src\mono\msvc\libmono-dynamic.vcxproj]
  F:\workspace\_work\1\s\src\mono\mono\metadata\mono-config.c(696,61): warning C4024: 'mono_config_parse_file_with_context': different types for formal and actual parameter 2 [F:\workspace\_work\1\s\src\mono\msvc\libmono-dynamic.vcxproj]
  F:\workspace\_work\1\s\src\mono\mono\metadata\mono-config.c(697,14): error C4022: 'monoeg_g_free': pointer mismatch for actual parameter 1 [F:\workspace\_work\1\s\src\mono\msvc\libmono-dynamic.vcxproj]
  F:\workspace\_work\1\s\src\mono\mono\metadata\mono-config.c(701,91): error C4047: '=': 'char' differs in levels of indirection from 'gchar *' [F:\workspace\_work\1\s\src\mono\msvc\libmono-dynamic.vcxproj]
  F:\workspace\_work\1\s\src\mono\mono\metadata\mono-config.c(702,61): error C4047: 'function': 'const char *' differs in levels of indirection from 'char' [F:\workspace\_work\1\s\src\mono\msvc\libmono-dynamic.vcxproj]
  F:\workspace\_work\1\s\src\mono\mono\metadata\mono-config.c(702,61): warning C4024: 'mono_config_parse_file_with_context': different types for formal and actual parameter 2 [F:\workspace\_work\1\s\src\mono\msvc\libmono-dynamic.vcxproj]
  F:\workspace\_work\1\s\src\mono\mono\metadata\mono-config.c(703,14): error C4022: 'monoeg_g_free': pointer mismatch for actual parameter 1 [F:\workspace\_work\1\s\src\mono\msvc\libmono-dynamic.vcxproj]

akoeplinger
akoeplinger reviewed Jul 28, 2020
View reviewed changes
@akoeplinger
Copy link
Member

akoeplinger commented Jul 28, 2020

Which also means we haven't kept these defines in sync with winconfig.h otherwise this code wouldn't have been compiled :D

@CoffeeFlux
[mono] Fix warnings on OSX netcore
bddb183 
This commit brings us back to zero warnings for the default build configuration
@CoffeeFlux CoffeeFlux force-pushed the more-warning-fixes branch from 502b51f to bddb183 Compare July 28, 2020 12:35
@CoffeeFlux
Copy link
Contributor Author

CoffeeFlux commented Jul 28, 2020

Yep, and that one's on me. Addressed here: #40005

@jaredpar jaredpar mentioned this pull request Jul 28, 2020
Closed
@CoffeeFlux CoffeeFlux merged commit ad93942 into dotnet:master Jul 28, 2020
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@CoffeeFlux @Jacksondr5
[mono] Fix warnings on OSX netcore (dotnet#39997)
c0f98ad 
This commit brings us back to zero warnings for the default build configuration
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@thaystg thaystg Awaiting requested review from thaystg

@lateralusX lateralusX Awaiting requested review from lateralusX

@alexischr alexischr Awaiting requested review from alexischr

@lambdageek lambdageek Awaiting requested review from lambdageek

@marek-safar marek-safar Awaiting requested review from marek-safar

+1 more reviewer

@vargaz vargaz vargaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-VM-meta-mono

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@CoffeeFlux @akoeplinger @vargaz @karelz @Dotnet-GitSync-Bot