Skip to content

Conversation

@layomia
Copy link
Contributor

@layomia layomia commented Jul 29, 2020

Contributes to #38033.

@layomia layomia added this to the 5.0.0 milestone Jul 29, 2020
@layomia layomia requested a review from marek-safar as a code owner July 29, 2020 17:30
@layomia layomia self-assigned this Jul 29, 2020
@ghost
Copy link

ghost commented Jul 29, 2020

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jkotas jkotas Jul 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this change need to be touching crossgen2? I would expect that we will run the linker analysis for libraries only.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to avoid the warnings (samples shown below) I was seeing locally relating to crossgen/crossgen2 and other projects changed in this PR by enabling verbose output on only libraries (i.e not mono/corelib System.Private.CoreLib). These warnings motivated most of the changes in this PR.

CROSSGEN-CORELIB : error : CrossGen System.Private.CoreLib build failed. Refer to D:\repos\dotnet_runtime\src\coreclr\..\..\artifacts\log\CrossgenCoreLib_Windows_NT__x64__Release.log [D:\repos\dotnet_runtime\src\coreclr\crossgen-corelib.proj]
EXEC : error : file "D:\repos\dotnet_runtime\src\coreclr\..\..\artifacts\bin\coreclr\Windows_NT.x64.Release\IL\System.Private.CoreLib.dll" or one of its dependencies was not found [D:\repos\dotnet_runtime\src\coreclr\crossgen-corelib.proj]
EXEC : error : Error enumerating files under D:\repos\dotnet_runtime\src\coreclr\..\..\artifacts\bin\coreclr\Windows_NT.x64.Release\IL\. [D:\repos\dotnet_runtime\src\coreclr\crossgen-corelib.proj]
D:\repos\dotnet_runtime\src\coreclr\crossgen-corelib.proj(20,5): error MSB3073: The command ""D:\repos\dotnet_runtime\src\coreclr\crossgen-corelib.cmd" -x64 -release" exited with code 1.

D:\repos\dotnet_runtime\.dotnet\sdk\5.0.100-preview.8.20362.3\Microsoft.Common.CurrentVersion.targets(4651,5): error MSB3030: Could not copy the file "D:\repos\dotnet_runtime\artifacts\bin\coreclr\OSX.x64.Release\clrjit.dll" because it was not found. [D:\repos\dotnet_runtime\src\coreclr\src\tools\aot\crossgen2\crossgen2.csproj]
D:\repos\dotnet_runtime\.dotnet\sdk\5.0.100-preview.8.20362.3\Microsoft.Common.CurrentVersion.targets(4651,5): error MSB3030: Could not copy the file "D:\repos\dotnet_runtime\artifacts\bin\coreclr\OSX.x64.Release\jitinterface.dll" because it was not found. [D:\repos\dotnet_runtime\src\coreclr\src\tools\aot\crossgen2\crossgen2.csproj]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here: What does ildasm packaging has to do with linker?

@layomia
Copy link
Contributor Author

layomia commented Jul 30, 2020

Closing this in favor of #40106 which enables verbose output for only libraries projects and avoids most of the changes in this PR.

@layomia layomia closed this Jul 30, 2020
@layomia layomia deleted the baselines_slim branch August 10, 2020 23:18
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants